Added Timeline UI for Bed Activity #6901
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Nice attempt, but couple of things:
-
It'd be nice to have the screenshot of the changes always attached if it's a UI change.
-
The folder name "BedAdministration" does not make sense.
-
The UI could be improved, like the "IN USE" chip seems to be relatively bigger than the surrounding elements. This can be made small.
-
The first element does not seem to have a connecting line to the second element.
-
The last element seems to have an unnecessary connecting line drawn to a no element existing beyond it. This can be removed.
There was a problem hiding this comment.
We are currently showing time in two places which is redundant.
Also can we improve the wording to something like this instead (just suggesting, feel free to add your creativity)
- Transferred to <b>{bed_name} in {location_name}</b> (relative time)
- Transferred to <b>{bed_name} in {location_name}</b> (relative time)
- Occupied <b>{bed_name} in {location_name}</b> (relative time)
I'll be working on some mockups and share them on channel |
|
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
rithviknishad
added
needs testing
and removed
changes required
Deploy-Failed
|
@thedevildude fix the lint |
|
@nihal467 not sure if the Lint workflow is providing correct results. Locally the said files doesn't have any linting errors. |
|
try re-installing the packages in your local. Recently the version has changed and seems to be causing similar issues for couple of contributors. Upgrading locally fixes it |
|
LGTM |
|
@thedevildude Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
What's Changed?
Before:
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist